feat/add_chain_1_12_updates #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, released in chain upgrade v1.12
Closed
achilleas-kal
approved these changes
Nov 3, 2023
source/includes/_authz.md
Outdated
| denom=network.fee_denom, | ||
| )] | ||
| tx = tx.with_gas(gas_limit).with_fee(fee).with_memo('').with_timeout_height(client.timeout_height) | ||
| gas_limit = sim_res.gas_info.gas_used + 20000 # add 20k for gas, fee computation |
There was a problem hiding this comment.
@aarmoa please replace the value of 20000 to 25000. After the last upgrade, gas was increased and 20K was not enough. Simulation might fail with 20K. The rest of the examples have been updated I think.
There was a problem hiding this comment.
Thank you for the heads up @achilleas-kal. I need to update the examples in the SDKs too. I will prepare the PRs
There was a problem hiding this comment.
I think the problem was that someone updated the buffer gas to 25k in the docs, but never applied the same change to the Python SDK repo examples
… Removed the list of sentry nodes and replaced the mention to k8s cluster for the mention of the load balanced node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to include all compatibility changes in the Python and Go SDKs for the chain upgrade to 1.12
This PR includes all changes for chain streams originally posted in #129
NOTE: