-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add_chain_1_12_updates #139
Conversation
…t, released in chain upgrade v1.12
source/includes/_authz.md
Outdated
denom=network.fee_denom, | ||
)] | ||
tx = tx.with_gas(gas_limit).with_fee(fee).with_memo('').with_timeout_height(client.timeout_height) | ||
gas_limit = sim_res.gas_info.gas_used + 20000 # add 20k for gas, fee computation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aarmoa please replace the value of 20000 to 25000. After the last upgrade, gas was increased and 20K was not enough. Simulation might fail with 20K. The rest of the examples have been updated I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the heads up @achilleas-kal. I need to update the examples in the SDKs too. I will prepare the PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem was that someone updated the buffer gas to 25k in the docs, but never applied the same change to the Python SDK repo examples
… Removed the list of sentry nodes and replaced the mention to k8s cluster for the mention of the load balanced node
Update documentation to include all compatibility changes in the Python and Go SDKs for the chain upgrade to 1.12
This PR includes all changes for chain streams originally posted in #129
NOTE: